Added support custom type and fixed bugs #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added Unmarshaler\Marshaler interfaces
- (fix) unmarshal NoneType to nil
- (refactoring) added supported for dict if key is not string - transform to map[interface{}]interface{}
- added packages for tests - added github.com/pkg/errors
b5
requested changes
May 14, 2020
Comment on lines
+136
to
+146
| case *starlarkstruct.Struct: | ||
| if _var, ok := v.Constructor().(Unmarshaler); ok { | ||
| err = _var.UnmarshalStarlark(x) | ||
| if err != nil { | ||
| err = errors.Wrapf(err, "failed marshal %q to Starlark object", v.Constructor().Type()) | ||
| return | ||
| } | ||
| val = _var | ||
| } else { | ||
| err = fmt.Errorf("constructor object from *starlarkstruct.Struct not supported Marshaler to starlark object: %s", v.Constructor().Type()) | ||
| } |
util/util.go
Outdated
Comment on lines
236
to
238
| type Unmarshaler interface { | ||
| UnmarshalStarlark(starlark.Value) error | ||
| } |
There was a problem hiding this comment.
This will cause golint to fail. Both the Unmarshaler interface and UnmarshalStarlark methods should have comments that explain their use.
util/util.go
Outdated
Comment on lines
240
to
242
| type Marshaler interface { | ||
| MarshalStarlark() (starlark.Value, error) | ||
| } |
There was a problem hiding this comment.
Same as Unmarshaler, this will cause golint to fail. Both the Marshaler interface and MarshalStarlark methods should have comments that explain their use.
Co-authored-by: Brendan O'Brien <sparkle_pony_2000@qri.io>
Co-authored-by: Brendan O'Brien <sparkle_pony_2000@qri.io>
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starlark.Dictif exists key as a not string