Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slug drop caused by 'REDIRECT_' prefix in '$_SERVER' variables coming from mod_rewrite #96

Closed
herrvigg opened this issue Jun 21, 2018 · 19 comments
Labels
enhancement New feature or request legacy issue Legacy issue imported from original repo

Comments

@herrvigg
Copy link
Collaborator

Issue by vonsch76
Monday Mar 23, 2015 at 08:51 GMT
Originally opened as qTranslate-Team/qtranslate-x#96


Have a new issue: When I try to check the woocommerce orders located under

wp-admin/edit.php?post_type=shop_order

then occasionally the slug is dropped and ends up at

wp-admin/edit.php

Current config: WC 2.2.11, qT-X 3.2.9, WC & qT-X 1.0.1

Actually it seems to be the same that causes 404 errors at the individual orders. The symptom seems to be the same, the slug after questionmark is dropped.

@herrvigg herrvigg added enhancement New feature or request legacy issue Legacy issue imported from original repo labels Jun 21, 2018
@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Monday Mar 23, 2015 at 23:08 GMT


It gets dropped on which action? First entrance? The latest on GitHub has yet another series of changes on converURL, could try it and see if the problem is still there? You can download it with 'Download ZIP' button on GitHub page or press here for the sake of convenience.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Tuesday Mar 24, 2015 at 06:00 GMT


John, OK will download from GitHub, test and let you know.

The action is unfortunately hectic, I was not able to spot any pattern. It
usually happens when the order is set to completed or when I click on
woocommerce or woocommerce new orders. It works fine in about 70% of the
time, though.

On 24 March 2015 at 00:08, johnclause notifications@github.com wrote:

It gets dropped on which action? First entrance? The latest on GitHub has
yet another series of changes on converURL, could try it and see if the
problem is still there? You can download it with 'Download ZIP' button on
GitHub https://github.com/qTranslate-Team/qtranslate-x page or press
here https://github.com/qTranslate-Team/qtranslate-x/archive/master.zip
for the sake of convenience.


Reply to this email directly or view it on GitHub
qTranslate-Team/qtranslate-x#96 (comment)
.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Tuesday Mar 24, 2015 at 10:06 GMT


Stability has increased, I would say it is about 95%, but still the error
remains.

On 24 March 2015 at 07:00, Kornel Schwarcz kornel.schwarcz@gmail.com
wrote:

John, OK will download from GitHub, test and let you know.

The action is unfortunately hectic, I was not able to spot any pattern. It
usually happens when the order is set to completed or when I click on
woocommerce or woocommerce new orders. It works fine in about 70% of the
time, though.

On 24 March 2015 at 00:08, johnclause notifications@github.com wrote:

It gets dropped on which action? First entrance? The latest on GitHub has
yet another series of changes on converURL, could try it and see if the
problem is still there? You can download it with 'Download ZIP' button on
GitHub https://github.com/qTranslate-Team/qtranslate-x page or press
here https://github.com/qTranslate-Team/qtranslate-x/archive/master.zip
for the sake of convenience.


Reply to this email directly or view it on GitHub
qTranslate-Team/qtranslate-x#96 (comment)
.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Wednesday Mar 25, 2015 at 08:09 GMT


It also happens when I click on an individual order. The correct slug would be

wp-admin/post.php?post=5707&action=edit

the landing page is

wp-admin/edit.php

95% was a bit optimistic, the stability is rather 85-90%, but better than it was.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Wednesday Mar 25, 2015 at 14:18 GMT


'better' does not solve the problem. I currently have no clue on what may be a cause. Could you make a test-copy of your live site and then play with activation/deactivation of plugins to find out which one is in conflict? First, it would be good to figure out a reproducible steps to see a problem.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Wednesday Mar 25, 2015 at 14:32 GMT


Correct. But better already gives you some relief. Have a copy of the site,
only need to update the database and the modules. Sorry, but it is highly
unlikely that I will have time for this today.

On 25 March 2015 at 15:18, johnclause notifications@github.com wrote:

'better' does not solve the problem. I currently have no clue on what may
be a cause. Could you make a test-copy of your live site and then play with
activation/deactivation of plugins to find out which one is in conflict?
First, it would be good to figure out a reproducible steps to see a problem.


Reply to this email directly or view it on GitHub
qTranslate-Team/qtranslate-x#96 (comment)
.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Thursday Mar 26, 2015 at 09:34 GMT


This will be a long struggle. First it seemed that heartbeat control causes the bug, but not. Unfortunately this seems to be a real bug, no real identifiable pattern.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Friday Mar 27, 2015 at 05:19 GMT


John, this is preliminary, but seems that I got the bug. The conflicting plugin is likely Yoast. After upgrading to Yoast 2.0 the bug never showed up. Also received some extra in the response speed as a bonus. Have about 12 hours of operation, though.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Friday Mar 27, 2015 at 10:07 GMT


Much better, but still not 100%. Sorry about the bad news, need to investigate more.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Friday Mar 27, 2015 at 22:21 GMT


If you turn off Yoast, does it happen? Or impossible to make such test?

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Friday Mar 27, 2015 at 23:33 GMT


I will try. My problem is rather that the error is not stable enough and
can not really reproduce similar conditions.

On 27 March 2015 at 23:21, johnclause notifications@github.com wrote:

If you turn off Yoast, does it happen? Or impossible to make such test?


Reply to this email directly or view it on GitHub
qTranslate-Team/qtranslate-x#96 (comment)
.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Monday Apr 06, 2015 at 01:17 GMT


Hi, I finally observed slug drop in Opera browser. Is Opera what you used too? Same action works fine for me in Chrome.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Monday Apr 06, 2015 at 05:41 GMT


Well, in fact, what I observed was a new bug in the development version, which is fixed by now in the latest on GitHub. That one was related to cookies. Maybe yours is too actually. Could you try the latest version from github, for example: https://github.com/qTranslate-Team/qtranslate-x/releases/tag/3.2.9.8.2 and see if you ever have it under this version? Thanks!

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Monday Apr 06, 2015 at 05:44 GMT


BTW, I am pretty sure there is an error message in error_log file. Can you look it up when it happens? You can also set WP_DEBUG to 'true' in your wp-config.php file, and then you may see an error message on the screen, when it happens.

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Monday Apr 06, 2015 at 06:42 GMT


Hi, No unfortunately the drop works for me in all browsers. I tend to use
Chrome, Firefox, Safari. The drop seems to me more stable.

The error logs have nothing on this, checking them regularly.

On 6 April 2015 at 03:17, johnclause notifications@github.com wrote:

Hi, I finally observed slug drop in Opera browser. Is Opera what you used
too? Same action works fine for me in Chrome.


Reply to this email directly or view it on GitHub
qTranslate-Team/qtranslate-x#96 (comment)
.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Monday Apr 06, 2015 at 15:51 GMT


Do you now have robust reproducing steps? Do you mind to make a test-copy of the site where I could login and troubleshoot?

@herrvigg
Copy link
Collaborator Author

Comment by vonsch76
Monday Apr 06, 2015 at 16:31 GMT


Jonh, Identical copy is set up with todays' database. You have full access
check your mails. Thanks, Kornel

On 6 April 2015 at 17:51, johnclause notifications@github.com wrote:

Do you now have robust reproducing steps? Do you mind to make a test-copy
of the site where I could login and troubleshoot?


Reply to this email directly or view it on GitHub
qTranslate-Team/qtranslate-x#96 (comment)
.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Tuesday Apr 07, 2015 at 05:03 GMT


I do not know, Kornel, I could never reproduce it. Is this the only URL which occasionally drops slug or there are more examples?

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Sunday Apr 12, 2015 at 13:42 GMT


We added check isset($_SERVER['REDIRECT_STATUS']) in function qtranxf_can_redirect to prevent another redirection if mod_rewrite is already doing redirection. In particular, this should help to troubleshoot internal server error 500 as it was observed here. Thanks a lot to @vonsch76 for cooperation and help to figure this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request legacy issue Legacy issue imported from original repo
Projects
None yet
Development

No branches or pull requests

1 participant