Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: delete on an empty cell shouldn't be in the undo/redo stack #481

Closed
jimniels opened this issue May 9, 2023 · 0 comments · Fixed by #494
Closed

bug: delete on an empty cell shouldn't be in the undo/redo stack #481

jimniels opened this issue May 9, 2023 · 0 comments · Fixed by #494
Assignees
Labels
type: bug something is broken

Comments

@jimniels
Copy link
Collaborator

jimniels commented May 9, 2023

Hitting "Delete" on a blank cell logs that as an event in the undo stack.

For example, in this gif, I hit the "Delete" key on a cell with a value, then I hit "Delete" on the cells below it, and then hit CMD + Z a number of times and each delete in a blank cell is an event in the stack and it moves the cursor to that cell (which feels weird, I would expect only the first "delete" that actually deleted a value to be in the stack of undos)

May-09-2023 11-38-03

@jimniels jimniels added the type: bug something is broken label May 9, 2023
@jimniels jimniels moved this to 💍 Building in Quadratic Roadmap May 17, 2023
@github-project-automation github-project-automation bot moved this from 💍 Building to Completed in Quadratic Roadmap May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug something is broken
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants