-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review required #1
Comments
No, just colors :D. but this shouldn't be done in the controller. Same as MovieCollectionView. In my mind: Rendering view should on a ViewClass, ViewController handle interaction (user events, computer events)
Yeah, it's obviously non obvious. But (x) button is mean clear the text box (maybe for another search). There must be another way like another button, another Tab for searching movies (I have thought about this way but would be time wasting)
At first I wanted to use it in detail view (you will notice that I load some more small data in detail view). But showing HUD while loading very small things is make user feel slowness. So I give it up, I forget about Podfile. You searched my name? I haven't done any movie yet lol |
Two "The Man from U.N.C.L.E.". It's themoviedb false, not mine. Btw, thanks for reviewing my assignment. I'll try my best on this week assignment. |
Top Rated crashed because old movies don't have release date field (in themoviedb) which I assumed that they should have. TopRated movies is random everyday, you know, many films have 10.0 point. |
Hi @chug2k,
I pushed the assignment, please review my project.
Thanks
The text was updated successfully, but these errors were encountered: