Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgrid 1.2.0 and 1.3.0 is not available on jsdelivr.com or unpkg.com #309

Open
DonJayamanne opened this issue Apr 20, 2020 · 7 comments
Open

Comments

@DonJayamanne
Copy link

Similar to issue #302

We Python extension in VS Code are adding support for ipywidgets in our implementation of notebooks.
We found that users installing the latest version of qgrid from pypi will never be able to get this working as the script isn't available on cdn for the latest versions.

Thanks.

@gerrymanoim
Copy link
Contributor

I believe this was addressed in #288

Upkg: https://unpkg.com/qgrid2@1.1.3/src/index.js
Jsdelivr: https://www.jsdelivr.com/package/npm/qgrid2

Conda-forge is still an open issue for now.

@DonJayamanne
Copy link
Author

DonJayamanne commented Apr 22, 2020

Upkg: unpkg.com/qgrid2@1.1.3/src/index.js

I'm referring to 1.3.0 not 1.1.3.

@gerrymanoim
Copy link
Contributor

Apologies - I'm not sure exactly what you mean.

Qgrid, the python package, is available on pypi: https://pypi.org/project/qgrid/ (1.3.1).
Qgrid2, the supporting npm package, is available on npm: https://www.npmjs.com/package/qgrid2

@DonJayamanne
Copy link
Author

Hmm, that will be an issue.
Based on the docs here this will not work for those trying to add support for qgrid outside of jupyter notebooks/lab. Basically the name of the module & version must match the name of the js module & version.

Ie we'll end up looking for https://unpkg.com/qgrid@1.3.0/dist/index.js

We can make an exception for qgrid and hardcode the js package name to be qgrid2, however the versions must match.

@jasongrout Do you have any recommendations here. Or am I missing something here?

@gerrymanoim
Copy link
Contributor

cc @richafrank @jbredeche - can we push the new js back to npm/qgrid and get the versions aligned?

@thedanielforum
Copy link

I would recommend adding publishing the package to npm as a step in the publish CI workflow.
That way we don't have to rely on the maintainers to remember to manually publish the releases to npm.

https://github.com/quantopian/qgrid/actions?query=workflow%3A%22Publish+Python+%F0%9F%90%8D+distributions+%F0%9F%93%A6+to+PyPI%22

@harrisliuwk
Copy link

harrisliuwk commented Nov 6, 2020

Hello, I recently found qgrid is so helpful in my exploratory data analysis workflow but unfortunately is incompatible with in-vscode jupyter notebook (even with jsdelivr.com and unpkg.com settings). It's good to know that if anyon is tracking this issue, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants