Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing error when importing cirq python 3.5.1 #710

Closed
ss2165 opened this issue Jul 18, 2018 · 4 comments
Closed

typing error when importing cirq python 3.5.1 #710

ss2165 opened this issue Jul 18, 2018 · 4 comments

Comments

@ss2165
Copy link

ss2165 commented Jul 18, 2018

Called from value/timestamp.py", line 59, in Timestamp

File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/typing.py", line 1184, in overload
    raise RuntimeError("Overloading is only supported in library stubs")
RuntimeError: Overloading is only supported in library stubs

when import cirq was called

Am I correct in thinking this version of python is supported?

@ss2165 ss2165 added bug and removed bug labels Jul 18, 2018
@Strilanc
Copy link
Contributor

Yes, thanks for catching this. I'll release a package with the correct constraints. (And I guess delete the old one, since otherwise 3.5.1 will just grab the bad one.)

@Strilanc
Copy link
Contributor

Fixed by #715

@maffoo
Copy link
Contributor

maffoo commented Jul 18, 2018

From the python 3.5.2 release notes it looks like the change to allow @overload outside stubs was already present in that version (https://docs.python.org/3.5/whatsnew/changelog.html#python-3-5-2-final). Was there another reason to skip 3.5.2 and require 3.5.3 instead?

@Strilanc
Copy link
Contributor

Nope. Was just being safe and fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants