GateWithRegisters.controlled does not work with call graph

[anurudhp]

#848 (comment)

Replacing Controlled(self.U, CtrlSpec(cvs=0)) with self.U.controlled(control_values=[0]) in GQSP results in:

AttributeError: 'BloqAsCirqGate' object has no attribute 'pretty_name'

Minimal code to reproduce error:

from qualtran.bloqs.basic_gates import XPowGate
from qualtran.bloqs.qsp.generalized_qsp import GeneralizedQSP
from qualtran.drawing import show_call_graph

gqsp = GeneralizedQSP.from_qsp_polynomial(XPowGate(), (0.5, 0.5))
g, _ = gqsp.call_graph(max_depth=1)
show_call_graph(g)

[mpharrigan]

I can't reproduce this on main. There was a recent PR merged that moved controlled to the bloqs one; maybe @tanujkhattar knows more

[anurudhp]

It still crashes for me on main, on replacing

Qualtran/qualtran/bloqs/qsp/generalized_qsp.py

Line 404 in 43e3032

counts.add((Controlled(self.U, CtrlSpec(cvs=0)), degree - self.negative_power))

with

counts.add((self.U.controlled(control_values=[0]), degree - self.negative_power))

(in build_call_graph)