Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineBeforeAnalysis enabled by default in coming GraalVM 21.3 release #19446

Closed
zakkak opened this issue Aug 17, 2021 · 1 comment · Fixed by #19511
Closed

InlineBeforeAnalysis enabled by default in coming GraalVM 21.3 release #19446

zakkak opened this issue Aug 17, 2021 · 1 comment · Fixed by #19511
Labels
kind/enhancement New feature or request
Milestone

Comments

@zakkak
Copy link
Contributor

zakkak commented Aug 17, 2021

Description

In 21.0 GraalVM introduced a new compiler flag -H:+InlineBeforeAnalysis (see oracle/graal#2594) and quarkus introduced a new build item for it (see #16134).

In 21.3-dev (latest GraalVM master) this flag has been turned on by default (see https://github.com/oracle/graal/pull/3628/files) making the builditem introduced by #16134 obsolete.

Implementation ideas

If we are OK with not being able to disable this flag, deprecating the build item once we upgrade to 21.3 should be fine.

If we would like to be able to pass -H:-InlineBeforeAnalysis by setting quarkus.native.inline-before-analysis to false or similar then extra steps are needed.

@zakkak
Copy link
Contributor Author

zakkak commented Sep 24, 2021

As discussed in #19511 (comment) there is currently at least one case where -H:-InlineBeforeAnalysis in conjunction with -H:ParseOnce is causing issues so being able to disable seems useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants