Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated projects are using @NativeImageTest, @QuarkusIntegrationTest should be pushed. #22560

Closed
rsvoboda opened this issue Dec 30, 2021 · 3 comments · Fixed by #21997
Closed

Generated projects are using @NativeImageTest, @QuarkusIntegrationTest should be pushed. #22560

rsvoboda opened this issue Dec 30, 2021 · 3 comments · Fixed by #21997
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/testing kind/bug Something isn't working
Milestone
2.8.0.CR1

Comments

@rsvoboda
Copy link
Member

Describe the bug

Generated projects are using @NativeImageTest, @QuarkusIntegrationTest should be pushed.

@QuarkusIntegrationTest was introduced with Quarkus 1.13, in guides (e.g. https://quarkus.io/guides/getting-started-testing#native-executable-testing) is mentioned as the way forward.

I think newly generated applications should use @QuarkusIntegrationTest at least for native testing.

Expected behavior

Generated projects are using @QuarkusIntegrationTest for native testing.

Actual behavior

Generated projects are using @NativeImageTest.

How to Reproduce?

Generate application using code.quarkus || quarkus cli || maven plugin.

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@rsvoboda rsvoboda added the kind/bug Something isn't working label Dec 30, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 30, 2021

/cc @geoand

@rsvoboda rsvoboda added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Dec 30, 2021
@geoand
Copy link
Contributor

geoand commented Jan 3, 2022

@ia3andy I thought we have already made this change

@famod famod linked a pull request Feb 6, 2022 that will close this issue
Move failsafe config out of native profile #21997
Merged
@geoand
Copy link
Contributor

geoand commented Mar 29, 2022

This was actually fixed by #23488

@geoand geoand closed this as completed Mar 29, 2022
@geoand geoand added this to the 2.8.0.CR1 milestone Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/testing kind/bug Something isn't working
Projects
None yet
Milestone
2.8.0.CR1
Development

Successfully merging a pull request may close this issue.

Move failsafe config out of native profile edeandrea/quarkus
2 participants
@rsvoboda @geoand