-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configuredisableURIValidation
for vertx http
#37804
Comments
disableURIValidation
for vertxdisableURIValidation
for vertx http
This issue is related (and could be fixed at once): #37789 |
Due to how core |
|
@cescoffier it's not entirely true The Java implementation or URI seems to not be following the RFC. Have a look to what OkHttp did on this topic: square/okhttp#1044 |
Hum, defining our own URI/URL class and following all the RFCs, that's looks lengthy and risky. |
@cescoffier I agree, not sure what the best way forward. As the current issue is with dev-mode, maybe we could have an option to disable it only in dev-mode? |
That's what I said also, specifically that I personally would not develop or maintain such a thing :) |
@ia3andy LEt me think a bit about it. We need to be absolutely sure we do not open an attack vector. Dev mode in a networked environment can be problematic (not sure about remote dev mode). |
Too risky. |
Description
Currently
vertx.disableURIValidation
is a hidden flag used in the vertx http recorder:https://github.com/quarkusio/quarkus/blob/main/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java#L117
We now have a use case for it in dev mode (Quinoa):
quarkiverse/quarkus-quinoa#591 (comment)
So we should provide a way to configure it from Quarkus config.
Implementation ideas
We could keep backward compat on this with the system props:
disabled if Boolean.getBoolean("vertx.disableURIValidation") or quarkus.http.disableURIValidation from config
The text was updated successfully, but these errors were encountered: