Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default datasource health check is up, without any url configured #41151

Closed
turing85 opened this issue Jun 12, 2024 · 4 comments
Closed

default datasource health check is up, without any url configured #41151

turing85 opened this issue Jun 12, 2024 · 4 comments
Labels
area/config area/health area/smallrye kind/bug Something isn't working triage/duplicate This issue or pull request already exists

Comments

@turing85
Copy link
Contributor

Describe the bug

The health check for the default datasource shows an UP status, without any url being configured.

Expected behavior

The application should fail to start, since the datasource is not configured correctly

Actual behavior

The health check for the default datasource shows an UP status

How to Reproduce?

Reproducer:

  • clone https://github.com/turing85/quarkus-camel-local-transactions
    git clone https://github.com/turing85/quarkus-camel-local-transactions.git
    cd quarkus-camel-local-transactions
  • look at the application.properties and verify that no database url is configured
  • build the application:
    ./mvnw --define skipTests clean package
  • run the application:
    QUARKUS_ARTEMIS_URL=tcp://localhost:5432 java -jar target/quarkus-app/quarkus-run.jar
  • access http://localhost:8080/q/health
  • notice that the health check for the database is up:
    {
      ...
      "checks": [
        ...
        {
          "name": "Database connections health check",
          "status": "UP",
          "data": {
            "<default>": "UP"
          }
        },
        ...
      ]
    }

Output of uname -a or ver

Linux xxx 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk 21.0.2 2024-01-16 LTS OpenJDK Runtime Environment Temurin-21.0.2+13 (build 21.0.2+13-LTS) OpenJDK 64-Bit Server VM Temurin-21.0.2+13 (build 21.0.2+13-LTS, mixed mode, sharing)

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

Copy link

quarkus-bot bot commented Jun 12, 2024

/cc @jmartisk (health), @radcortez (config), @xstefank (health)

@geoand
Copy link
Contributor

geoand commented Jun 12, 2024

Is this different than #41152?

It looks like a duplicate

@turing85
Copy link
Contributor Author

uh... yeah... it is... how did this duplicate?

@geoand geoand added the triage/duplicate This issue or pull request already exists label Jun 12, 2024
@geoand
Copy link
Contributor

geoand commented Jun 12, 2024

Stuff happens :)

@yrodiere yrodiere closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/health area/smallrye kind/bug Something isn't working triage/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants