Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Throwable in startup error log message #5058

Closed
brunoabdon opened this issue Oct 31, 2019 · 2 comments
Closed

Include Throwable in startup error log message #5058

brunoabdon opened this issue Oct 31, 2019 · 2 comments
Labels
kind/bug Something isn't working
Milestone

Comments

@brunoabdon
Copy link

Describe the bug
The error log message "Failed to start Quarkus, attempting to start hot replacement endpoint to recover" should include the Throwable that caused it.

This is at this line:

log.error("Failed to start Quarkus, attempting to start hot replacement endpoint to recover");

Expected behavior
Show the Throwable info on error log.

Actual behavior
Throwable instance is swallowed.

Suggestion
Just pass tas second parameter:

log.error("Failed to start Quarkus, attempting to start hot replacement endpoint to recover",t);

@jaikiran
Copy link
Member

#5061

@gsmet gsmet added this to the 0.28.0 milestone Oct 31, 2019
@Sanne
Copy link
Member

Sanne commented Oct 31, 2019

I think we can consider this resolved by #5061 : closing

@Sanne Sanne closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants