Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spring-web wildcard syntax in @RequestMapping #5370

Closed
johnaohara opened this issue Nov 11, 2019 · 5 comments
Closed

Support spring-web wildcard syntax in @RequestMapping #5370

johnaohara opened this issue Nov 11, 2019 · 5 comments
Assignees
Labels
area/spring Issues relating to the Spring integration kind/bug Something isn't working
Milestone

Comments

@johnaohara
Copy link
Member

johnaohara commented Nov 11, 2019

Describe the bug
Spring-web RequestMapping allows for wildcard definitions within paths that have a different syntax from valid jax-rs paths.

In order to facilitate support of spring-web applications without developers having to re-define path mappings, quarkus should fully support the spring-web syntax in @RequestMapping definitions.

Expected behavior
e.g @GetMapping("/wildcard/*/{name}") should map /wildcard/1/Quarkus, currently returns HTTP 404, whereas /wildcard/*/Quarkus returns HTTP 200

@RequestMapping("/car?/s?o?/info") should also map urls "/cars/shop/info" and "/cart/show/info"

To Reproduce
Steps to reproduce the behavior:

  1. git clone git@github.com:johnaohara/quarkusSpringWebWildcards.git
  2. cd quarkusSpringWebWildcards
  3. mvn clean test
@johnaohara johnaohara added kind/bug Something isn't working area/spring Issues relating to the Spring integration labels Nov 11, 2019
@geoand
Copy link
Contributor

geoand commented Nov 11, 2019

@asoldano @patriot1burke @FroMage does JAX-RS not support expressions like @PATH("/wildcard/*/{name}")?

@geoand
Copy link
Contributor

geoand commented Nov 11, 2019

Excellent, thanks @asoldano!

@geoand
Copy link
Contributor

geoand commented Nov 12, 2019

RESTEasy PR opened to address these cases. Once it's been merged and released I can update Quarkus to add some tests cases for this

@gsmet gsmet closed this as completed Nov 15, 2019
@gsmet gsmet added this to the 1.0.0.Final milestone Nov 15, 2019
@geoand
Copy link
Contributor

geoand commented Nov 15, 2019

I forgot to add tests, but actually they shouldn't be needed since all relevant the tests were added in RESTEasy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/spring Issues relating to the Spring integration kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants