Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align and simplify Hibernate ORM configuration name #560

Closed
emmanuelbernard opened this issue Jan 17, 2019 · 2 comments
Closed

Align and simplify Hibernate ORM configuration name #560

emmanuelbernard opened this issue Jan 17, 2019 · 2 comments
Assignees
Milestone

Comments

@emmanuelbernard
Copy link
Member

shamrock.hibernate.orm.*
And we can move away from the JPA or Hibernate ORM names.

Things to change:

  • config group
  • a couple of exceptions do reference the property names so they need to align
  • the documentation needs to be updated.

Proposal:

  • shamrock.hibernate.dialect -> shamrock.hibernate-orm.dialect
  • shamrock.hibernate.schema-generation.database.action -> shamrock.hibernate-orm.schema-generation
  • shamrock.hibernate.show_sql -> shamrock.hibernate-orm.log-sql
  • shamrock.hibernate.sql-load-script-source -> shamrock.hibernate-orm.sql-load-script
@n1hility
Copy link
Member

@gsmet any update on this one? Should we just defer what remains?

@gsmet
Copy link
Member

gsmet commented Feb 27, 2019

I'm currently working on it. Should be done by tomorrow.

@gsmet gsmet added this to the 0.11.0 milestone Mar 3, 2019
@gsmet gsmet closed this as completed Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants