Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC expiration-grace property name is misleading #8627

Closed
sberyozkin opened this issue Apr 16, 2020 · 0 comments · Fixed by #8658
Closed

OIDC expiration-grace property name is misleading #8627

sberyozkin opened this issue Apr 16, 2020 · 0 comments · Fixed by #8658
Assignees
@sberyozkin
Labels
area/oidc kind/bug Something isn't working
Milestone
1.5.0.CR1

Comments

@sberyozkin
Copy link
Member

sberyozkin commented Apr 16, 2020 •
edited
Loading

Describe the bug
As noted in #8469, quarkus.oidc.token.expiration-grace is misleading. I originally named it this way because I thought the Vertx leeway property was only about the expiration grace but it is effectively a lifespan grace.

Proposal is to rename it now to avoid any confusions going forward, effectively quarkus.oidc.token.expiration-grace name is a bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sberyozkin sberyozkin

Labels
area/oidc kind/bug Something isn't working
Projects
None yet
Milestone
1.5.0.CR1
Development

Successfully merging a pull request may close this issue.

Rename OIDC expiration-grace property to lifespan-grace sberyozkin/quarkus
2 participants
@sberyozkin @gsmet