Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py and ui-tests included in wheel #5

Closed
lahwaacz opened this issue Feb 17, 2024 · 3 comments
Closed

setup.py and ui-tests included in wheel #5

lahwaacz opened this issue Feb 17, 2024 · 3 comments

Comments

@lahwaacz
Copy link

The pyproject.toml file includes setup.py and ui-tests in the wheel:
https://github.com/quarto-dev/jupyterlab-quarto/blob/4a14120293910fe2877c6437397aedb9aaab4c9c/pyproject.toml#L40C1-L40C91

They appear directly under site-packages where they pollute the global module space (the names don't associate to jupyterlab-quarto):

python3.11/site-packages/jupyterlab-quarto/
python3.11/site-packages/jupyterlab-quarto/__init__.py
python3.11/site-packages/jupyterlab-quarto/_version.py
python3.11/site-packages/jupyterlab_quarto-0.3.2.dist-info/
python3.11/site-packages/jupyterlab_quarto-0.3.2.dist-info/METADATA
python3.11/site-packages/jupyterlab_quarto-0.3.2.dist-info/RECORD
python3.11/site-packages/jupyterlab_quarto-0.3.2.dist-info/WHEEL
python3.11/site-packages/jupyterlab_quarto-0.3.2.dist-info/licenses/
python3.11/site-packages/jupyterlab_quarto-0.3.2.dist-info/licenses/LICENSE
python3.11/site-packages/setup.py
python3.11/site-packages/ui-tests/
python3.11/site-packages/ui-tests/jupyter_server_test_config.py
@dragonstyle
Copy link
Contributor

Thanks for reporting this- I just update the package to remove these.

@lahwaacz
Copy link
Author

Ugh, you probably forgot to commit the change - the v0.3.3 tag is on a commit from yesterday... 🤷

@dragonstyle
Copy link
Contributor

TY! I had just forgotten to push my changes. I've updated the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants