Fix issue found with quoting of sidebar navigation items and missing rel attribute

Author: cderv

news/changelog-1.5.md

@@ -62,6 +62,8 @@ All changes included in 1.5:
 - ([#8986](https://github.com/quarto-dev/quarto-cli/issues/8986)): Search: only build subfuse index when it's safe to do so.
 - ([#9356](https://github.com/quarto-dev/quarto-cli/issues/9356)): Don't process column classes for figures inside the About divs.
 - ([#9781](https://github.com/quarto-dev/quarto-cli/issues/9781)): Correctly hide elements from click event in collapsed margin sidebar.
+- Sidebar navigation item now correctly supports `rel` attribute.
+- `target` attribute for sidebar navigation items is now correctly inserted with HTML escapes.
 
 ## Book
 

src/resources/projects/website/templates/sidebaritem.ejs

@@ -3,7 +3,7 @@
 <% if (item.href && item.text && !item.contents) { %>
 <li class="sidebar-item">
   <div class="sidebar-item-container"> 
-  <a href="<%- item.href %>" class="sidebar-item-text sidebar-link<%- item.active ? " active" : "" %>"<%- item.target ? ` target="${item.target}"` : "" %>><% partial('navicon.ejs', { item }) %> <span class="menu-text"><%= item.text %></span></a>
+  <a href="<%- item.href %>" class="sidebar-item-text sidebar-link<%- item.active ? " active" : "" %>"<%= item.rel ? ` rel="${item.rel}"` : "" %><%= item.target ? ` target="${item.target}"` : "" %>><% partial('navicon.ejs', { item }) %> <span class="menu-text"><%= item.text %></span></a>
   </div>
 </li>
 <% } else if (item.contents && item.text) { %>  
@@ -19,7 +19,7 @@
     <% if (item.contents.length > 0) { %>
       <div class="sidebar-item-container"> 
           <% if (item.href) { %>
-            <a href="<%- item.href %>" class="sidebar-item-text sidebar-link<%- item.active ? " active" : "" %>"<%- item.target ? ` target="${item.target}"` : "" %>><% partial('navicon.ejs', { item }) %> <span class="menu-text"><%= item.text %></span></a>
+            <a href="<%- item.href %>" class="sidebar-item-text sidebar-link<%- item.active ? " active" : "" %>"<%= item.rel ? ` rel="${item.rel}"` : "" %><%= item.target ? ` target="${item.target}"` : "" %>><% partial('navicon.ejs', { item }) %> <span class="menu-text"><%= item.text %></span></a>
           <% } else { %> 
             <a class="sidebar-item-text sidebar-link text-start<%- isCollapsed ? " collapsed" : "" %>" data-bs-toggle="collapse" data-bs-target="#<%- sectionId %>"  role="navigation" aria-expanded="<%- isCollapsed ? "false" : "true" %>"><% partial('navicon.ejs', { item }) %> <span class="menu-text"><%= item.text %></span></a>
           <% }  %>      

tests/docs/smoke-all/2024/06/12/9969/.gitignore

@@ -0,0 +1,2 @@
+/.quarto/
+_site

tests/docs/smoke-all/2024/06/12/9969/_quarto.yml

@@ -0,0 +1,26 @@
+project:
+  type: website
+
+website:
+  title: "Sidebar-target"
+  navbar:
+    left:
+      - href: index.qmd
+        text: Home
+  sidebar:
+    contents:
+      - href: https://quarto.org
+        target: _blank
+        rel: external
+        text: Quarto website
+      - text: PRERELEASE
+        href: https://prerelease.quarto.org
+        target: _blank
+        rel: external
+        contents:
+          - href: https://prerelease.quarto.org
+            target: _blank
+            rel: external
+            text: Quarto prerelease website
+
+format: html

tests/docs/smoke-all/2024/06/12/9969/index.qmd

@@ -0,0 +1,18 @@
+---
+title: "Sidebar-target"
+_quarto:
+  tests:
+    html:
+      ensureHtmlElements:
+        - 
+          - 'nav#quarto-sidebar a[target="_blank"].sidebar-link'
+          - 'nav#quarto-sidebar a[rel="external"].sidebar-link'
+        - 
+          - "nav#quarto-sidebar a[target='\"_blank\"']"
+          - "nav#quarto-sidebar a[rel='\"external\"']"
+          - "nav#quarto-sidebar a.sidebar-link:not([rel])"
+---
+
+This is a Quarto website.
+
+To learn more about Quarto websites visit <https://quarto.org/docs/websites>.