brand logo shortcode: don't add class if variant specified

it's a potential footgun and anyone who wants this can build it themself

Author: gordonwoodhull

news/changelog-1.8.md

@@ -4,7 +4,8 @@
 
 - ([#13383](https://github.com/quarto-dev/quarto-cli/issues/13383)): Fix failure when combining `minimal: true` with brand.yml.
 - ([#13396](https://github.com/quarto-dev/quarto-cli/issues/13396)): Fix `quarto publish connect` regression.
-- ([#13418](https://github.com/quarto-dev/quarto-cli/issues/13418): Resolve logo paths specified directly in `brand.logo.{size}`.
+- ([#13418](https://github.com/quarto-dev/quarto-cli/issues/13418)): Resolve logo paths specified directly in `brand.logo.{size}`.
+- ([#13445](https://github.com/quarto-dev/quarto-cli/pull/13445)): Brand logo shortcode will not add `.light-content`, `.dark-content` classes when `light` or `dark` is specifically requested.
 
 # v1.8 changes
 

src/resources/filters/quarto-pre/shortcodes-handlers.lua

@@ -174,12 +174,14 @@ function initShortcodeHandlers()
       end
       local images = {}
       if lightLogo then
+        local classes = brandMode == 'both' and {"light-content"} or {}
         table.insert(images, pandoc.Image(pandoc.Inlines {}, add_leading_slash(lightLogo.path), "",
-          pandoc.Attr("", {"light-content"}, {alt = lightLogo.alt})))
+          pandoc.Attr("", classes, {alt = lightLogo.alt})))
       end
       if darkLogo then
+        local classes = brandMode == 'both' and {"dark-content"} or {}
         table.insert(images, pandoc.Image(pandoc.Inlines {}, add_leading_slash(darkLogo.path), "",
-          pandoc.Attr("", {"dark-content"}, {alt = darkLogo.alt})))
+          pandoc.Attr("", classes, {alt = darkLogo.alt})))
       end
       if context == "block" then
         return pandoc.Blocks(images)

tests/docs/smoke-all/shortcodes/brand-logo-dark.qmd

@@ -13,7 +13,7 @@ _quarto:
     html:
       ensureFileRegexMatches:
         -
-          - '<img src="\.(/|\\)moon\.png" class="dark-content.*>'
+          - '<img src="\.(/|\\)moon\.png" class="img-fluid.*>'
         - []
 ---
 

tests/docs/smoke-all/shortcodes/brand-logo-fallback-light.qmd

@@ -6,26 +6,20 @@ brand:
     logo:
       small: dark-logo.png
       medium: dark-medium-logo.png
-      # No light logo specified
+      large: dark-large-logo.png
 _quarto:
   tests:
     html:
       ensureFileRegexMatches:
         - 
-          # When requesting dark mode explicitly, should get dark logo
-          - '<img src="\.(/|\\)dark-logo\.png" class="dark-content.*>'
-          # When requesting light mode explicitly (which doesn't exist), should fall back to dark logo but with light-content class
-          - '<img src="\.(/|\\)dark-logo\.png" class="light-content.*>'
-          # When requesting medium size with light mode (doesn't exist), should fall back to dark-medium with light-content class
-          - '<img src="\.(/|\\)dark-medium-logo\.png" class="light-content.*>'
+          - '<img src="\.(/|\\)dark-logo\.png" class="img-fluid.*>'
+          - '<img src="\.(/|\\)dark-medium-logo\.png" class="img-fluid.*>'
+          - '<img src="\.(/|\\)dark-large-logo\.png" class="img-fluid.*>'
         - []
 ---
 
-### Dark Logo (Dark Mode)
 {{< brand logo small dark >}}
 
-### Dark Logo (Light Mode - should fall back)
-{{< brand logo small light >}}
+{{< brand logo medium light >}}
 
-### Medium Logo (Light Mode - should fall back)
-{{< brand logo medium light >}}
+{{< brand logo large light >}}

tests/docs/smoke-all/shortcodes/brand-logo-fallback.qmd

@@ -6,26 +6,20 @@ brand:
     logo:
       small: light-logo.png
       medium: light-medium-logo.png
-      # No dark logo specified
+      large: light-large-logo.png
 _quarto:
   tests:
     html:
       ensureFileRegexMatches:
         - 
-          # When requesting light mode explicitly, should get light logo
-          - '<img src="\.(/|\\)light-logo\.png" class="light-content.*>'
-          # When requesting dark mode explicitly (which doesn't exist), should fall back to light logo but with dark-content class
-          - '<img src="\.(/|\\)light-logo\.png" class="dark-content.*>'
-          # When requesting medium size with dark mode (doesn't exist), should fall back to light-medium with dark-content class
-          - '<img src="\.(/|\\)light-medium-logo\.png" class="dark-content.*>'
+          - '<img src="\.(/|\\)light-logo\.png" class="img-fluid.*>'
+          - '<img src="\.(/|\\)light-medium-logo\.png" class="img-fluid.*>'
+          - '<img src="\.(/|\\)light-large-logo\.png" class="img-fluid.*>'
         - []
 ---
 
-### Light Logo (Light Mode)
 {{< brand logo small light >}}
 
-### Light Logo (Dark Mode - should fall back)
-{{< brand logo small dark >}}
+{{< brand logo medium dark >}}
 
-### Medium Logo (Dark Mode - should fall back)
-{{< brand logo medium dark >}}
+{{< brand logo large dark >}}

tests/docs/smoke-all/shortcodes/brand-logo-light.qmd

@@ -13,7 +13,7 @@ _quarto:
     html:
       ensureFileRegexMatches:
         -
-          - '<img src="\.(/|\\)sun\.png" class="light-content.*>'
+          - '<img src="\.(/|\\)sun\.png" class="img-fluid.*>'
         - []
 ---