Merge pull request #9973 from quarto-dev/bugfix/8656

lua,latex - don't crash on captionless tables in subfloats

Author: cscheid

news/changelog-1.5.md

@@ -18,6 +18,7 @@ All changes included in 1.5:
 ## PDF Format
 
 - ([#8299](https://github.com/quarto-dev/quarto-cli/issues/8299)): Don't use `rsvg-convert` to convert an SVG to PDF when the PDF is already available; add `use-rsvg-convert` option to control this behavior.
+- ([#8656](https://github.com/quarto-dev/quarto-cli/issues/8656)): Don't crash on captionless tables in subfloats.
 - ([#8684](https://github.com/quarto-dev/quarto-cli/issues/8684)): Improve detection and automatic installation of locale specific hyphenation files.
 - ([#8711](https://github.com/quarto-dev/quarto-cli/issues/8711)): Enforce rendering of tables as `tabular` environments when custom float environments are present.
 - ([#8841](https://github.com/quarto-dev/quarto-cli/issues/8841)): Do not parse LaTeX table when crossref label doesn't start with `tbl-`.

src/resources/filters/layout/latex.lua

@@ -351,13 +351,16 @@ function latexCell(cell, vAlign, endOfRow, endOfTable)
       content:insert(pandoc.Para(caption))
       cellOutput = true
     elseif isFigure then
-      local caption = refCaptionFromDiv(cell).content
-      markupLatexCaption(cell, caption)
-      content:insert(pandoc.RawBlock("latex", "\\raisebox{-\\height}{"))
-      tappend(content, tslice(cell.content, 1, #cell.content-1))
-      content:insert(pandoc.RawBlock("latex", "}"))
-      content:insert(pandoc.Para(caption)) 
-      cellOutput = true
+      local caption_el = refCaptionFromDiv(cell)
+      if caption_el ~= nil then
+        local caption = caption_el.content
+        markupLatexCaption(cell, caption)
+        content:insert(pandoc.RawBlock("latex", "\\raisebox{-\\height}{"))
+        tappend(content, tslice(cell.content, 1, #cell.content-1))
+        content:insert(pandoc.RawBlock("latex", "}"))
+        content:insert(pandoc.Para(caption)) 
+        cellOutput = true
+      end
     end
   end
 

tests/docs/smoke-all/2024/06/12/8656.qmd

@@ -0,0 +1,51 @@
+---
+title: "test"
+format: latex
+---
+
+:::: {#tbl-test layout-ncol="2"}
+
+::: {#tbl-test1}
+
+```{=html}
+<table>
+  <thead>
+    <tr>
+      <th>test</th>
+      <th>test</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <td>test</td>
+      <td>test</td>
+    </tr>
+  </tbody>
+</table>
+```
+
+:::
+
+::: {#tbl-test2}
+
+```{=html}
+<table>
+  <thead>
+    <tr>
+      <th>test</th>
+      <th>test</th>
+    </tr>
+  </thead>
+  <tbody>
+    <tr>
+      <td>test</td>
+      <td>test</td>
+    </tr>
+  </tbody>
+</table>
+```
+
+:::
+
+Test
+::::