Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Pixi installation of Quarto in the VS Code Extension #573

Closed
roaldarbol opened this issue Oct 17, 2024 · 4 comments
Closed

Detect Pixi installation of Quarto in the VS Code Extension #573

roaldarbol opened this issue Oct 17, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@roaldarbol
Copy link

I'm installing Quarto with pixi, which means the executable is located within the project, and lives at:

.pixi/envs/default/bin/quarto

It would be great to have the VS Code extension automatically detect this installation, like it does venv and others, if a .pixi folder is present.

@cderv cderv added the enhancement New feature or request label Oct 17, 2024
@cscheid
Copy link
Contributor

cscheid commented Oct 17, 2024

I don't think we should be getting in the business of supporting every package manager out there. venv is effectively the Python standard and gets special treatment by VS Code, and that's why we support it. I'm sorry, but I'm going to go ahead and close this one; we don't have the resources to do this well enough, and I don't think we will in the near future.

@cscheid cscheid closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
@roaldarbol
Copy link
Author

I think that's an unfortunate choice, especially with the extension being a cornerstone in Positron.
I personally know very few people who actually use the base venv, whereas especially conda-based tools are widely used, and uv is also getting a lot of traction. Now, uv saves into .venv by default, so I imagine that is already autodetected. All other conda venv's install into global caches (and so does Poetry); pixi is the only one that does so within the project. Python installations from pixi is already being discovered by the vs-code-python extension, and is also discovered in Positron.

As far as I can tell from the source code, you already support conda too, which is great as it's widely used. If I read the source correctly (which I may not be), you're basically just checking whether there exists a Quarto installation in the same place as the Python Interpreter is located; so essentially it's mostly relaxing some constraints in python.ts on where that is allowed to be.

It's of courser completely up to you, but I think it would be worth discussing with the Positron team too before completely dismissing the idea.

@cscheid
Copy link
Contributor

cscheid commented Oct 17, 2024

To clarify:

My decision is not out of a desire to not support Pixi. It's a decision based on the other things we have to support. We're happy to revisit that decision in light of more data, and if you're willing to contribute a PR, we would likely even take it. But as a feature request for us to do, I stand by my original point: I don't see it coming to the top of our priority list, and I don't think letting this issue linger open will help anyone.

@roaldarbol
Copy link
Author

Makes complete sense, I can definitely see your points. I'm actually surprised by the numbers, but they speak for themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants