Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant tap delay from q-route-tab component in Android #1517

Closed
Frondor opened this issue Jan 31, 2018 · 3 comments
Closed

Significant tap delay from q-route-tab component in Android #1517

Frondor opened this issue Jan 31, 2018 · 3 comments

Comments

@Frondor
Copy link
Contributor

Frondor commented Jan 31, 2018

Issue related to #1269

Software version

Quasar: 0.14.7
Browsers: Chrome (with devtools' android emulator), Android, Webview
Android: 5.1 (didn't test in iOS)

Demo https://youtu.be/iHTzxNyQw60

On chrome dev tools android emulator (device toolbar) and chrome browser (android app), there's some delay after tapping a router-link tab.

Looks like the underlying implementation of router-link component has some performance issue.

If I have to give my $ 0.50, I'd blame $nextTick here

this.checkIfSelected()

Isn't it possible to get rid of all that router link mixin / implementation and simply work with programmatic navigation? Thus working with this.$router.replace (and getting rid of that watcher) in computed properties for the element state / classes?

Code

    <q-tabs slot="footer"
      position="bottom"
      :color="appColor"
      align="justify"
      :two-lines="false"
      class="non-selectable">
      <q-route-tab replace to="/route/tab1"
        icon="devices_other"
        slot="title" />
      <q-route-tab replace to="/route/tab2"
        icon="store"
        slot="title" />
      <q-route-tab replace to="/route/tab3"
        icon="room_service"
        slot="title" />
      <q-route-tab replace to="/route/tab4"
        icon="local_activity"
        slot="title" />
    </q-tabs>

Although in this example looks like it works fine https://codesandbox.io/s/381l9rz8wm so I don't really know atm

Tried some recommendations from this article https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away hoping that the 300ms rule were the one to blame here but no, no success.

I strongly believe the problem is within q-route-tab component, because normal q-tab are working just fine.

@rstoenescu
Copy link
Member

@Frondor Can you reproduce this with v0.15 too?

@Frondor
Copy link
Contributor Author

Frondor commented Feb 19, 2018

Closing this as I can't reproduce it outside of my project. disregarding quasar's version.

@Frondor Frondor closed this as completed Feb 19, 2018
@rstoenescu
Copy link
Member

Let me know if I can help in any way, but after v0.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants