Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments will cause the QDialog Plugin to throw errors #16526

Closed
carvenl opened this issue Oct 27, 2023 · 1 comment
Closed

Comments will cause the QDialog Plugin to throw errors #16526

carvenl opened this issue Oct 27, 2023 · 1 comment
Labels

Comments

@carvenl
Copy link

carvenl commented Oct 27, 2023

What happened?

When customizing components, comments can cause the QDialog component to throw errors:

[Quasar] Incorrectly defined Dialog component

What did you expect to happen?

If you delete this comment or write the comment inside QDialog, this Error will not occur.

Reproduction URL

https://stackblitz.com/edit/quasarframework-bm3tua?file=src%2Fpages%2FIndexPage.vue,src%2Fcomponents%2FMyDialog.vue

How to reproduce?

  1. Clicking the Btn in IndexPage.vue will cause the console to report an error [Quasar] Incorrectly defined Dialog component.
  2. If you delete the comments in MyDialog.vue, this Error will not occur.

Flavour

Quasar CLI with Vite (@quasar/cli | @quasar/app-vite)

Areas

Components (quasar), Plugins (quasar)

Platforms/Browsers

Chrome

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@carvenl carvenl added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Oct 27, 2023
@github-actions github-actions bot added area/components area/plugins bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-vite labels Oct 27, 2023
@pdanpdan
Copy link
Collaborator

duplicate #16153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants