Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build with go 1.12 #2

Closed
DeadNumbers opened this issue Mar 1, 2019 · 3 comments
Closed

Can't build with go 1.12 #2

DeadNumbers opened this issue Mar 1, 2019 · 3 comments
Assignees
@quasilyte
Labels
bug Something isn't working

Comments

@DeadNumbers
Copy link

vendor/github.com/Quasilyte/concat.Strings: relocation target runtime.mallocgc not defined for ABI0 (but is defined for ABIInternal)
@quasilyte quasilyte added the bug Something isn't working label Mar 1, 2019
@quasilyte quasilyte self-assigned this Mar 1, 2019
@quasilyte
Copy link
Owner

I'll take a look.

@quasilyte
Copy link
Owner

I believe golang/go@685aca4 is the reason (golang/go#27539).

Not 100% sure how to fix build now, since runtime symbols are part of the internal ABI.

@quasilyte
Copy link
Owner

It could be possible to try something that is described in http://www.alangpierce.com/blog/2016/03/17/adventures-in-go-accessing-unexported-functions/ if it still works, but the better option is to:

  1. Stick to non-assembly version. I can probably disable asm amd64 version for go1.12 and above targets.
  2. Don't use concat as a library.

I wonder, do you really have a need for such thing as a library? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quasilyte quasilyte

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quasilyte @DeadNumbers