Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version on Pypi not compatible with setuptools #18

Closed
rex911 opened this issue Nov 18, 2021 · 3 comments
Closed

Latest version on Pypi not compatible with setuptools #18

rex911 opened this issue Nov 18, 2021 · 3 comments

Comments

@rex911
Copy link

rex911 commented Nov 18, 2021

setuptools recently mandated checking for newlines: pypa/setuptools@a4b7cae

We're observing errors while installing skcriteria with setuptools:

``
10:08:12 cwd: /tmp/pip-install-6vgy8g_3/scikit-criteria_a188aa38d71246558652ef0768f8ca3b/
10:08:12 Complete output (29 lines):
10:08:12 Warning: 'classifiers' should be a list, got type 'tuple'
10:08:12 running egg_info
10:08:12 creating /tmp/pip-pip-egg-info-v0lih8ua/scikit_criteria.egg-info
10:08:12 writing /tmp/pip-pip-egg-info-v0lih8ua/scikit_criteria.egg-info/PKG-INFO
10:08:12 Traceback (most recent call last):
10:08:12 File "", line 1, in
10:08:12 File "/tmp/pip-install-6vgy8g_3/scikit-criteria_a188aa38d71246558652ef0768f8ca3b/setup.py", line 115, in
10:08:12 do_setup()
10:08:12 File "/tmp/pip-install-6vgy8g_3/scikit-criteria_a188aa38d71246558652ef0768f8ca3b/setup.py", line 103, in do_setup
10:08:12 install_requires=REQUIREMENTS,
10:08:12 File "/var/lib/jenkins/workspace/pummel_PR-148-5IDUTEJ55KBJ2X3SZN5AW6R3R7KENFHATMRIO6JRRCA2QV3Y7OFA/.nox/linter/lib/python3.7/site-packages/setuptools/init.py", line 153, in setup
10:08:12 return distutils.core.setup(**attrs)
10:08:12 File "/usr/lib/python3.7/distutils/core.py", line 148, in setup
10:08:12 dist.run_commands()
10:08:12 File "/usr/lib/python3.7/distutils/dist.py", line 966, in run_commands
10:08:12 self.run_command(cmd)
10:08:12 File "/usr/lib/python3.7/distutils/dist.py", line 985, in run_command
10:08:12 cmd_obj.run()
10:08:12 File "/var/lib/jenkins/workspace/pummel_PR-148-5IDUTEJ55KBJ2X3SZN5AW6R3R7KENFHATMRIO6JRRCA2QV3Y7OFA/.nox/linter/lib/python3.7/site-packages/setuptools/command/egg_info.py", line 292, in run
10:08:12 writer(self, ep.name, os.path.join(self.egg_info, ep.name))
10:08:12 File "/var/lib/jenkins/workspace/pummel_PR-148-5IDUTEJ55KBJ2X3SZN5AW6R3R7KENFHATMRIO6JRRCA2QV3Y7OFA/.nox/linter/lib/python3.7/site-packages/setuptools/command/egg_info.py", line 656, in write_pkg_info
10:08:12 metadata.write_pkg_info(cmd.egg_info)
10:08:12 File "/usr/lib/python3.7/distutils/dist.py", line 1117, in write_pkg_info
10:08:12 self.write_pkg_file(pkg_info)
10:08:12 File "/var/lib/jenkins/workspace/pummel_PR-148-5IDUTEJ55KBJ2X3SZN5AW6R3R7KENFHATMRIO6JRRCA2QV3Y7OFA/.nox/linter/lib/python3.7/site-packages/setuptools/dist.py", line 167, in write_pkg_file
10:08:12 write_field('Summary', single_line(self.get_description()))
10:08:12 File "/var/lib/jenkins/workspace/pummel_PR-148-5IDUTEJ55KBJ2X3SZN5AW6R3R7KENFHATMRIO6JRRCA2QV3Y7OFA/.nox/linter/lib/python3.7/site-packages/setuptools/dist.py", line 151, in single_line
10:08:12 raise ValueError('Newlines are not allowed')
10:08:12 ValueError: Newlines are not allowed```

It seems the latest release on Pypi 0.2.11 has this issue

>>> import skcriteria
>>> skcriteria.DOC
'Scikit-Criteria is a collections of algorithms, methods and\ntechniques for multiple-criteria decision analysis.\n\n'
>>> skcriteria.VERSION
'0.2.11'

whereas the current master does not:

techniques for multiple-criteria decision analysis."""

@leliel12
Copy link
Collaborator

I just uploaded the version 0.5.dev0, i still need to write a simple "quickstart" and in this week the version 0.5 must be published

@leliel12
Copy link
Collaborator

Version 0.5 published! please check the new tutorial https://scikit-criteria.readthedocs.io/en/latest/tutorial/quickstart.html

@rex911
Copy link
Author

rex911 commented Dec 15, 2021

Thank you for the new release.

Setuptools also has a new release (pypa/setuptools#2893 (comment)) to fix the originally reported issue. I'll close it now.

@rex911 rex911 closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants