-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: add command to update go packages with norm_version #1915
Conversation
Local output:
|
Do we want this to be |
I think the issue with it not being go-specific is; is the version parsing logic and the |
I meant for the command itself -- are we ever going to need another |
15ad6c3
to
68780ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
68780ec
to
c90fca5
Compare
4b8bb00
to
301b7b7
Compare
There are a number of Go packages in the `package` table that do not have the needed norm_version which is required for Go matching. Signed-off-by: crozzy <joseph.crosland@gmail.com>
Add the ability to check migration version of the database before running an admin command so you know you are operating on a compatible database schema. Signed-off-by: crozzy <joseph.crosland@gmail.com>
301b7b7
to
1f2b34f
Compare
There are a number of Go packages in the
package
table that do not have the needed norm_version which is required for Go matching.This looks up the potential Go packages from the
matcher.vuln
table, the difficultly doing this is entirely in the indexer DB is how to identify that these packages came from the gobin scanner. Trying to use thepackage_scanartifact
(joining to thescanners
table is prohibitively expensive as the query path is not accounted for in the index (i.e. we're always expecting the first clause to the the layer_id).