Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colon ':' breaks GET /ancestry/ REST API #747

Closed
KeyboardNerd opened this issue Mar 21, 2019 · 3 comments
Closed

Colon ':' breaks GET /ancestry/ REST API #747

KeyboardNerd opened this issue Mar 21, 2019 · 3 comments
Labels
kind/bug things are not as they seem
Milestone

Comments

@KeyboardNerd
Copy link
Contributor

Description of Problem / Feature Request

when we request ancestry API with something like
/ancestry/sha256:12345

It will return 404 directly.

Expected Outcome

Actual Outcome

Environment

  • Clair version/image: master
  • Clair client name/version:
  • Host OS:
  • Kernel (e.g. uname -a):
  • Kubernetes version (use kubectl version):
  • Helm version (use helm version):
  • Network/Firewall setup:
@KeyboardNerd KeyboardNerd added kind/bug things are not as they seem component/api labels Mar 21, 2019
@KeyboardNerd KeyboardNerd added this to the v3.0.0 milestone Mar 21, 2019
@KeyboardNerd
Copy link
Contributor Author

This is a known issue in gRPC gateway.
grpc-ecosystem/grpc-gateway#224

@KeyboardNerd
Copy link
Contributor Author

apparently because of backward compat issue, they are not going to resolve this problem.
I guess either to redesign this gateway API or change the dependency to be the commit before reverting "allowing colon" PR.

@hdonnay
Copy link
Member

hdonnay commented Aug 31, 2020

We’re declaring bug bankruptcy as part of the release process for a new major version of Clair. Please open a ticket in our issue tracker if you feel this still needs to be addressed, and we'll triage as part of our v4 development process. Thanks!

@hdonnay hdonnay closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug things are not as they seem
Development

No branches or pull requests

2 participants