Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please set a user agent #141

Closed
BenTheElder opened this issue Jul 11, 2024 · 3 comments · Fixed by #142
Closed

please set a user agent #141

BenTheElder opened this issue Jul 11, 2024 · 3 comments · Fixed by #142

Comments

@BenTheElder
Copy link

It took me a while to track down

wellKnownEndpoint = "/.well-known/app-capabilities"
and since there's no user agent set I can't be certain ... but we get a LOT of requests to https://registry.k8s.io for this non-standard endpoint (which isn't in the OCI registry spec nor https://www.iana.org/assignments/well-known-uris/well-known-uris.xhtml) and they all have generic Go HTTP client as the user agent.

Please consider setting a user agent so server operators know what the client is.

@BenTheElder
Copy link
Author

BenTheElder commented Jul 11, 2024

... also, is there anything we can do to avoid users attempting to scan this API against registry.k8s.io? This seems to be something quay specific ...?

(not important, just seems odd to see a quay-specific API being accessed on other hosts ...?)

@HammerMeetNail
Copy link
Contributor

Hey @BenTheElder , I created https://issues.redhat.com/browse/PROJQUAY-7472 for us to track. This seems like a straightforward ask, we'll review on Monday and work to roll it into a z-stream release in the coming weeks. We'll talk through hitting that path on other hosts too and get back to you.

@BenTheElder
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants