Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx offset is needed for requesting tx sign? #2

Open
serendipity-seeker opened this issue Jan 7, 2025 · 0 comments
Open

tx offset is needed for requesting tx sign? #2

serendipity-seeker opened this issue Jan 7, 2025 · 0 comments

Comments

@serendipity-seeker
Copy link

await window.ethereum.request({
      method: 'wallet_invokeSnap',
      params: {
        snapId: defaultSnapOrigin,
        request: {
          method: 'signTransaction',
          params: {
            base64Tx,
            accountIdx,
            offset,
          },
        },
      },
    });

when requesting sign tx, we need to pass offset.
I am not sure it is needed.
In tx, signature part is last 64 byte, so we can just eliminate last 64 byte from passed transaction and just sign it - it will be okay.

const { base64Tx, offset, accountIdx = 0, confirm = true } = request.params || {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant