Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked version of timm dependency #620

Closed
ligaz opened this issue Jul 29, 2022 · 8 comments
Closed

Locked version of timm dependency #620

ligaz opened this issue Jul 29, 2022 · 8 comments
Labels

Comments

@ligaz
Copy link

ligaz commented Jul 29, 2022

Is there a reason to depend on specific version of PyTorch Image Models timm==0.4.12 instead of using something like >=0.4.12 as a version specifier?

The context for the question is this issue.

@qubvel
Copy link
Collaborator

qubvel commented Jul 29, 2022

The reason is that API tends to change, especially in such quick-developing libraries as timm! In one day you can appear with not working code because of that, I prefer to fix the version, but you can always update it after installing.

@adamjstewart
Copy link
Collaborator

Would it be possible to lock it based on semver to something like >=0.4.12,<0.7? Also, would it be possible to update the locked version so we can use newer timm? In TorchGeo, we use dependabot to check to see if new versions break compatibility and use semver pins for all dependencies. This has proven to be extremely stable for us.

I've noticed that this isn't exactly the first issue to request support for modern versions of timm...

Given that one of the most popular feature requests in this library is upgrading the version of timm, I think it's safe to say that the current solution is problematic.

@qubvel
Copy link
Collaborator

qubvel commented Jul 29, 2022

I have updated timm version, but a new version, unfortunately, breaks the code
https://github.com/qubvel/segmentation_models.pytorch/runs/7586507780?check_suite_focus=true

@qubvel
Copy link
Collaborator

qubvel commented Jul 29, 2022

I will fix and update it later, there are some changes, not seeing a quick fix for it

@adamjstewart
Copy link
Collaborator

Yeah, looks like TorchGeo doesn't work with segmentation_models_pytorch 0.3 either: microsoft/torchgeo#692. Hoping we can figure out how to support both 0.2 and 0.3 so we don't have to pin to a specific version.

@JulienMaille
Copy link
Contributor

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 29, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants