Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Objective to Trajectory #118

Open
goerz opened this issue May 26, 2024 · 0 comments
Open

Rename Objective to Trajectory #118

goerz opened this issue May 26, 2024 · 0 comments
Labels
breaking PRs that break compatibility enhancement New feature or request
Milestone

Comments

@goerz
Copy link
Member

goerz commented May 26, 2024

See JuliaQuantumControl/QuantumControl.jl#59:

The term "objective" was originally taken from the krotov Python package, but has been a considerable source of misunderstanding. People (rightfully) get confused about "objectives" which are separate from the optimization functional. Especially when talking about a perfect entangler optimization where the objectives/trajectories have no target state, I always have to explain that 'objectives' is a misnomer, and that these are just the states whose dynamics enter the functional. The term "trajectory" is more accurate, as it consists of the initial state and the dynamical generator. Any (optional) additional properties (target_state, weight, …) are best understood as extra information specific to that trajectory that the functional may use.

The release of QuTiP 5 seems like a good opportunity to release krotov v2.0, which in turn is an opportunity to make this breaking change. This will also bring the krotov package closer again to the newer QuantumControl.jl, and would have made the Python and Julia versions of the Tutorial for the recent Optimal Control Workshop more similar.

@goerz goerz added enhancement New feature or request breaking PRs that break compatibility labels May 26, 2024
@goerz goerz added this to the 2.0 milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking PRs that break compatibility enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant