Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the parameter space #51

Closed
laserroger opened this issue Aug 27, 2019 · 1 comment
Closed

Limit the parameter space #51

laserroger opened this issue Aug 27, 2019 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@laserroger
Copy link

laserroger commented Aug 27, 2019

  • Krotov version: dev version
  • Python version: 3.6.8
  • Operating System: macOS 10.13

Description

Currently the optimization method has no limit on the parameter space. For example, in the case of "simple state to state", the S(t) is initially set to be within [0, 1] but this range no longer holds. This agrees with practical consideration where the maximal B_x is limited.

@goerz goerz added the duplicate This issue or pull request already exists label Aug 27, 2019
@goerz
Copy link
Member

goerz commented Aug 27, 2019

I don't have the full context of what you did, but if you are referring to the S(t) e.g. in cell 6 of https://krotov.readthedocs.io/en/stable/notebooks/01_example_simple_state_to_state.html, this function is not the control field! This "shape" function regulates the update of the field in each iteration (when S(t) = 0, the control field is never updated for that value of t, when S(t) = 1, the update is maximally large). The control field is not in the range [0, 1].

You're certainly not the first person to be confused by this, and the current (still unreleased) master branch of krotov takes some steps to try to make this more explicit, mostly by renaming "shape" to "update_shape", and not reusing S(t) in the control field in the examples, cf. the master-branch version of that same example notebook at https://krotov.readthedocs.io/en/latest/notebooks/01_example_simple_state_to_state.html. There, the control field is defined in cell 2, and is completely unrelated to the update-shape in cell 8.

Still, you are right that the krotov package currently does not allow to place amplitude constraints on the control field. However, this is not a fundamental limitation of Krotov's method, see https://krotov.readthedocs.io/en/latest/09_howto.html#how-to-limit-the-amplitude-of-the-controls, and the implementation of this feature is planned for a future release, see #23.

Closing as duplicate of #23.

@goerz goerz closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants