Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfurl links that don't have oEmbed provider #100

Open
anindha opened this issue May 5, 2020 · 3 comments
Open

Unfurl links that don't have oEmbed provider #100

anindha opened this issue May 5, 2020 · 3 comments

Comments

@anindha
Copy link

anindha commented May 5, 2020

I want to replicate the behaviour of Slack or Twitter where all links are transformed into either embeded content or link previews.

I want to merge some of the logic from gatsby-remark-link-unfurl.

Please let me know what you think.

@raae
Copy link
Member

raae commented May 5, 2020

That sounds awesome!

It could maybe also be a choice for each provider what to do, maybe for YouTube you do want the embed. But for Twitter, you would like to turn it off and use the unfurl approach instead.

@anindha
Copy link
Author

anindha commented May 5, 2020

@raae I put up a POC that works for the base case. Your suggestion for having it configurable for each url is a good one. I'll have a think how to do that. Please let me know if you have any comments. I am still not sure the best way to style the preview card.

@raae
Copy link
Member

raae commented May 5, 2020

I was thinking per provider. In the same way we have for other provider specific settings. I have a lot going right now, but will try to have a look at your POC before the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants