-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arch Linux build is broken #538
Comments
This is caused by version 70 of the icu library. It added support for Unicode 14, which changed data for some symbols. |
Despite having version 70 of icu, Arch Linux' Python and Go still have Unicode 13 tables. I guess we gotta rewrite tools/generate-lex-unicode in C++ to take advantage of icu. Alternatively, we could parse Unicode tables ourselves. I think esbuild's script parses Unicode tables. EDIT: Nevermind; it uses a library which pre-parsed Unicode tables. |
Idea A: disable the lex-unicode tests entirely or unless Unicode 13 tables are in use Idea B: use Unicode 14 tables; require Unicode 14 in lex-unicode tests Idea C: use Unicode 14 tables; adjust lex-unicode tests to allow false positives compared to installed icu (risky) Idea D: use union of Unicode 3, 13, 14, etc. tables (support as many standards as possible; allow false negative diagnostics for certain JS versions); adjust lex-unicode tests to allow false positives compared to installed icu (risky) |
Build fixed by implementing idea B in commit c506297. |
quick-lint-js-test-lex-unicode is failing.
The text was updated successfully, but these errors were encountered: