Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Linux build is broken #538

Closed
strager opened this issue Nov 24, 2021 · 5 comments
Closed

Arch Linux build is broken #538

strager opened this issue Nov 24, 2021 · 5 comments
Assignees

Comments

@strager
Copy link
Collaborator

strager commented Nov 24, 2021

quick-lint-js-test-lex-unicode is failing.

@strager strager added this to the public release (v1.0) milestone Nov 24, 2021
@strager
Copy link
Collaborator Author

strager commented Nov 24, 2021

@strager strager self-assigned this Nov 26, 2021
@strager
Copy link
Collaborator Author

strager commented Nov 26, 2021

This is caused by version 70 of the icu library. It added support for Unicode 14, which changed data for some symbols.

@strager
Copy link
Collaborator Author

strager commented Nov 26, 2021

Despite having version 70 of icu, Arch Linux' Python and Go still have Unicode 13 tables.

I guess we gotta rewrite tools/generate-lex-unicode in C++ to take advantage of icu. Alternatively, we could parse Unicode tables ourselves. I think esbuild's script parses Unicode tables. EDIT: Nevermind; it uses a library which pre-parsed Unicode tables.

@strager
Copy link
Collaborator Author

strager commented Nov 26, 2021

Idea A: disable the lex-unicode tests entirely or unless Unicode 13 tables are in use

Idea B: use Unicode 14 tables; require Unicode 14 in lex-unicode tests

Idea C: use Unicode 14 tables; adjust lex-unicode tests to allow false positives compared to installed icu (risky)

Idea D: use union of Unicode 3, 13, 14, etc. tables (support as many standards as possible; allow false negative diagnostics for certain JS versions); adjust lex-unicode tests to allow false positives compared to installed icu (risky)

@strager
Copy link
Collaborator Author

strager commented Nov 26, 2021

Build fixed by implementing idea B in commit c506297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant