Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto register ibc denoms for host zone and osmosis on zone registration #1458

Open
joe-bowman opened this issue Apr 18, 2024 · 1 comment
Open
Assignees

Comments

@joe-bowman
Copy link
Contributor

Summary

Given we are able to compute the ibc denom for a new qAsset on another chain deterministically, we should automatically do so for at least the host zone, and osmosis (perhaps all chains for which we have a connectionData?) at the point of zone registration, in the same way we do for LocalZone and for ConnectionData.

@joe-bowman
Copy link
Contributor Author

see x/particpationrewards/keeper/hooks.go: AfterZoneCreated method.

This creates ConnectionProtocolData, and LiquidAllowedDenomProtocolData for the Quicksilver zone.

We want to additionally create LiquidAllowedDenomProtocolData for:

  • host zone (zone.ChainID)
  • osmosis (chainID from OsmosisParamsProtocolData) (we don't want to hard code this, because it won't be correct for testnet)
  • umee (chainID from UmeeParamsProtocolData) (we don't want to hard code this, because it won't be correct for testnet)

You'll need to fetch these PDs and decode them to fetch the ChainIDs; you'll want to fetch the transfer channels from ConnectionData for these zones (post #1459 completion) and use the DeriveIBCDenom in utils to determine the denom.

This will probably suffice for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants