-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lenient parser in bindings #109
Comments
Concerning the |
I posted #114 as a strawman for how this might look. I played around with using a base class, but there are some challenges with using them with PyO3. I've commented specifically on the PR and in the code about this. |
Now that quickwit-oss/tantivy#2129 has landed, it'd be nice to start thinking about lenient parsing support in the bindings. Obviously, a new version of the crate has to be released but starting to think about this.
I've started working on this, but there are a few points I'd like to iron out how we'd expose the
QueryParserError
enum. It'd be nice to have types for the errors, butQueryParserError
is currently a Rust enum.An (strawman) idea I had was to have separate classes for each error type. Then, optionally, organize them in a submodule underneath
tantivy
, i.e.tantivy.query_parser_error
or something. Then, the interface could look something like this from the Python side:cc @adamreichold @cjrh if y'all have thoughts
The text was updated successfully, but these errors were encountered: