Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting tantivy and call for official maintainers #618

Open
fulmicoton opened this issue Aug 8, 2019 · 9 comments
Open

Splitting tantivy and call for official maintainers #618

fulmicoton opened this issue Aug 8, 2019 · 9 comments

Comments

@fulmicoton
Copy link
Collaborator

The addition of tantivy-py is the most exciting thing I have seen in tantivy in the last month :)

So far, in the wild, ppl have been using tantivy with C#, node, lua, elixir, with different grades of bindings. I think tantivy-search should host some (python, and maybe C and or node) promising bindings, in order to ensure their perennity and so that these project benefit from tantivy-search growing community...

But that does not mean I should be their main maintainer. In fact, I should probably not dissolve my time further.

@poljar we kind of have been throwing you issues here and there, but just to officialize this, are you ok to be official maintainer of your own project? (you already have the write access of course).

Does someone else want to take over the search-benchmark ? Same question for tantivy-cli ?

@poljar
Copy link

poljar commented Aug 8, 2019

Sure, maintaining the bindings shouldn't be a big burden anyways. Apart from the possible API changes around them and adding support for differing collectors there's not much stuff going on there.

Of course not counting possible API changes on the rust tantivy side.

@fulmicoton
Copy link
Collaborator Author

Finding the best way to package it for PyPI. Advertise. ....
And then routing the occasional bug report to tantivy when relevant. :)

@poljar
Copy link

poljar commented Aug 8, 2019

There is already a test package up https://test.pypi.org/project/tantivy/
Finding a way to build the python documentation will be needed, that's true. And the CI setup. So a little bit more than I mentioned but not by much.

@fulmicoton
Copy link
Collaborator Author

@poljar Would there be a way to ship binaries or is it too much of a rabbit hole?

@poljar
Copy link

poljar commented Aug 8, 2019

Should be possible. pyo3-pack should make that easier, we still will need to use setuptools to build the source dist.

One pyo3 project that has a working CI setup and publishes binary wheels is fastuuid.

@fulmicoton
Copy link
Collaborator Author

I mostly scared of the libc. Here is a site describing accurately what can and cannot be done.
https://www.python.org/dev/peps/pep-0513/#key-causes-of-inter-linux-binary-incompatibility

@poljar
Copy link

poljar commented Aug 8, 2019

pyo3-pack takes this into consideration and the fastuuid lib does use a docker image to build the wheels, more info here: https://github.com/PyO3/pyo3-pack#manylinux-and-auditwheel

@hntd187
Copy link
Contributor

hntd187 commented Aug 14, 2019

I can likely take over the search benchmark and tantivy cli, it was my plan to integrate both these tools into toshi both for benchmarking and also cli tools for toshi

@fulmicoton
Copy link
Collaborator Author

@hntd187
cli tools for toshi > That would be great ! We could then sunset tantivy-cli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants