-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting tantivy and call for official maintainers #618
Comments
Sure, maintaining the bindings shouldn't be a big burden anyways. Apart from the possible API changes around them and adding support for differing collectors there's not much stuff going on there. Of course not counting possible API changes on the rust tantivy side. |
Finding the best way to package it for PyPI. Advertise. .... |
There is already a test package up https://test.pypi.org/project/tantivy/ |
@poljar Would there be a way to ship binaries or is it too much of a rabbit hole? |
Should be possible. pyo3-pack should make that easier, we still will need to use setuptools to build the source dist. One pyo3 project that has a working CI setup and publishes binary wheels is fastuuid. |
I mostly scared of the libc. Here is a site describing accurately what can and cannot be done. |
pyo3-pack takes this into consideration and the fastuuid lib does use a docker image to build the wheels, more info here: https://github.com/PyO3/pyo3-pack#manylinux-and-auditwheel |
I can likely take over the search benchmark and tantivy cli, it was my plan to integrate both these tools into toshi both for benchmarking and also cli tools for toshi |
@hntd187 |
The addition of
tantivy-py
is the most exciting thing I have seen in tantivy in the last month :)So far, in the wild, ppl have been using tantivy with C#, node, lua, elixir, with different grades of bindings. I think tantivy-search should host some (python, and maybe C and or node) promising bindings, in order to ensure their perennity and so that these project benefit from tantivy-search growing community...
But that does not mean I should be their main maintainer. In fact, I should probably not dissolve my time further.
@poljar we kind of have been throwing you issues here and there, but just to officialize this, are you ok to be official maintainer of your own project? (you already have the write access of course).
Does someone else want to take over the
search-benchmark
? Same question fortantivy-cli
?The text was updated successfully, but these errors were encountered: