Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples assume that 0 is not a valid packet number #299

Closed
marten-seemann opened this issue Jul 19, 2024 · 0 comments · Fixed by #300
Closed

examples assume that 0 is not a valid packet number #299

marten-seemann opened this issue Jul 19, 2024 · 0 comments · Fixed by #300

Comments

@marten-seemann
Copy link
Contributor

But it is.

In example 1, receiving packet 3 should trigger an ACK, since this would allow the peer to declare packet 0 lost (3-0 >= 3).
Instead of changing which ACKs are sent, the easiest solution would be adding another line for packet 0 to the table.

@marten-seemann marten-seemann changed the title examples assumes that 0 is not a valid packet number examples assume that 0 is not a valid packet number Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant