Quill 1.3.x broke interactive embeds

[guillaumepotier]

Steps for Reproduction

1. See how quill 1.2.6 handled embeds here : https://codepen.io/guillaumepotier/pen/WEqrBd
2. See how quill 1.3.x handle embeds now : https://codepen.io/guillaumepotier/pen/gxNPma

Problem:

In my project, I mix text and rich contents in the editor/page, rendered and handled by React. See screenshot :

I want to be able to interact with them, for te task, edit it (this is a contenteditable div), for the embed below to select a provider then enter url, title, etc...

With 1.3.0

Fix cursor interaction with custom contenteditable=false embeds

As you can see in the two codepens, this is now impossible to interact with them, Quill puts cursor after the element, prevent having focus on input/textarea/contenteditable, opens bubble from theme...

I'm aware my usage might be very special and un-standard, but I chose Quill for my project just for this ability to make my editor much richer with specific contents for my app.

How could we possibly fix that behavior, while keeping the good work it produced for #1172 #1181 ?

I'd really like not to be jailed on 1.2.6 on Quill.. Or at least, help me narrow the commits changes to fork the repo and try to maintain myself Quill without this "feature" ?

Thanks a lot

Platforms:

Latest Chrome

[jhchen]

The root seems to be the .ql-embed-selected feature which was based on the assumption that usually you want to select the thing you click on but this does not appear to be true in a lot of cases (like this) so I think I might just remove this feature.

[guillaumepotier]

Hi @jhchen, thanks for your answer!

Glad to read that this behaviour is not as uncommon as I may though :)

Two comments on that :

• This reverted feature might be good for some usages no? Might it be something you want to keep and configurable through options?
• More generally, won't it be possible to think about a way to "modularize" selection or at least some behaviours of it? I did not dig enough in the code but it seems that this.selection = new Selection(this.scroll, this.emitter); in Quill constructor might be limiting. Might be possible to give it to constructor in options, and kept that way if none given?

Thanks again a lot for your work. And btw if you're interested by a glance on our product built around Quill, tell me I'd be glad to give you a private beta access by email.

Best

[jhchen]

It was a bit experimental in the first place and it introduced more issues than it is worth. I may re-introduce it in the future if it's use is more clear to avoid ongoing maintenance cost and complexity if it is not.

I'm always happy to see Quill used in real products feel free to send an email jhchen7@gmail.com