Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change alignment attached to a button #816

Closed
stalniy opened this issue Jul 25, 2016 · 1 comment
Closed

Unable to change alignment attached to a button #816

stalniy opened this issue Jul 25, 2016 · 1 comment

Comments

@stalniy
Copy link

stalniy commented Jul 25, 2016

I have this markup:

<div #toolbar>
  <span class="btn-group">
    <button type="button" class="ql-align btn" value=""></button>
    <button type="button" class="ql-align btn" value="center"></button>
  </span>
</div>
<div #editorPlaceholder></div>

When I click on first button I want alignment to be left.

Steps for Reproduction

  1. Visit http://jsfiddle.net/8k81cojh/1/
  2. type some text inside editor
  3. Click on "center" button
  4. Click on "left" button

Expected behavior: [expected]
text is aligned to the left

Actual behavior: [actual]
text is centered

Platforms: [ex. Chrome 48 on Mac 10.11]
Chrome 51.0.2704.103 Mac 10+

Version: [version]
beta.9

@stalniy stalniy changed the title Unable to remove formatting with button Unable to change alignment attached to a button Jul 25, 2016
@stalniy
Copy link
Author

stalniy commented Jul 25, 2016

the issue is in https://github.com/quilljs/quill/blob/develop/modules/toolbar.js#L87
there is no way to pass false as a button value

@jhchen jhchen closed this as completed in 7da527a Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant