-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar is active when the editor is disabled #909
Comments
This commit improves the enable/disable handling of the quill instance. It introduces a new event called `STATE_CHANGE` which gets emitted when the global `enable()` function is called. Closes slab#909.
Was this bug fixed already ? |
I'm still seeing it. I'm adding my toolbar to its own container, if that helps. EDIT: Ah yes, this is still an issue with "strict" set to Also, the toolbar-container didn't matter after all: |
Actually I think the |
@jhchen Stackblitz - https://stackblitz.com/edit/js-cspmsm?file=index.html |
When the editor is disabled, the toolbar should be disabled too.
Maybe the editor should tell all the modules that its status is changed.
Some modules might still want to stay enabled even when the editor is disabled.
For example a multi-cursor module might still want to show the cursors of other users.
I also can't find a way to enable/disable a single module.
Steps for Reproduction
Expected behavior:
Nothing should happen because the editor is disabled.
Actual behavior:
The title 'Quill Rich Text Editor' is turned into a list.
Platforms:
Firefox 48 on Windows 7
Version:
1.0.0-rc4
The text was updated successfully, but these errors were encountered: