Improve inserting performance #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
force-pushed
the
zh-insert-contents
branch
10 times, most recently
from
c6f6269
to
99bf79f
Compare
luin
commented
Jun 30, 2023
| block.formatAt(0, length, key, value); | ||
| }); | ||
|
|
||
| return block; |
There was a problem hiding this comment.
Changing to:
return block.statics.requiredContainer
? block.wrap(block.statics.requiredContainer.blotName)
: block;Decreases the rendering time for /stress by 500ms but not super sure if it's safe so this PR leaves it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
Quill#setContentsperformance by usinginsertBefore()whenever possible.