Provide a paste-manager api to customize final delta. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @container = @quill.addContainer('ql-paste-manager') | ||
| @container.setAttribute('contenteditable', true) | ||
| dom(@quill.root).on('paste', _.bind(this._paste, this)) | ||
| @options = _.defaults(options, { containerToDelta: this._containerToDelta }) |
There was a problem hiding this comment.
Can you structure this similar to other modules where there's a DEFAULTS static: https://github.com/quilljs/quill/blob/develop/src/modules/image-tooltip.coffee#L10. Can we also name the config onConvert (that's the best I could come up with... might be a better name still but I think containerToDelta is too long and context dependent).
yyjhao
force-pushed
the
paste_container_to_delta
branch
from
d153aff to
2db704e
Compare
|
Hi I have updated the diff, can you take a look again? |
jhchen
added a commit
that referenced
this pull request
Jun 26, 2015
Provide a paste-manager api to customize final delta
|
Awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier for post-processing the pasted data without having to rewrite the paste manager or wait for the text-change event.