Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Content Types #13

Closed
chrisduerr opened this issue Jun 26, 2019 · 5 comments
Closed

Handle Content Types #13

chrisduerr opened this issue Jun 26, 2019 · 5 comments

Comments

@chrisduerr
Copy link

Using x11-clipboard through the clipboard-rust crate, it seems like content types lead to timeouts whenever trying to paste something.

This has been reported to Alacritty in alacritty/alacritty#2595.

I'd expect that when the content type is set to text/plain, everything should work the same way it does when no content type is set. Currently this operation times out.

If an image is loaded, I'd expect it to fail, however I'd expect it to fail instantly. Currently the operation also times out.

@quininer
Copy link
Owner

Currently all non-target types are ignored, and it seems that throwing an error is the right thing to do. As for text/plain, we need to set multiple targets, which requires changing some APIs.

I will try to fix it later.

@chrisduerr
Copy link
Author

Thanks! Just to clarify, I personally don't care about non-text content types at all, since Alacritty won't ever have to handle them as far as I'm concerned. However, even then a quick error is obviously preferable over a long blocking timeout.

@quininer
Copy link
Owner

@chrisduerr Can you try to see if this commit 0746c0e is valid?

@quininer quininer reopened this Jun 27, 2019
@chrisduerr
Copy link
Author

I can't reproduce any blocking issues anymore, so seems to be working great!

Supporting explicitly set text content types would be the only remaining issue, however that's far less of a priority for me personally. So if that's gonna take a while and require API changes, a non-breaking fix release might be reasonable first.

@quininer
Copy link
Owner

0.3.3 has been released!

I will close this issue now and multiple target support will trace in #7. I don't remember why I didn't implement it immediately. If I have time, I will look at it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants