Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompiling for thread-safety #12

Closed
randyzwitch opened this issue Jan 10, 2020 · 5 comments
Closed

Recompiling for thread-safety #12

randyzwitch opened this issue Jan 10, 2020 · 5 comments

Comments

@randyzwitch
Copy link

Ref: JuliaMath/DecFP.jl#39 (comment)

Per the other thread, it appears that we can make DecFP.jl thread-safe through a compiler flag. Now that 1.3 is out with the threading functionality, this will start to lead to more silent-ish errors unless we fix it.
@jmkuhn
Copy link
Contributor

jmkuhn commented Mar 4, 2020 •
edited
Loading

I'd like to make a PR for this issue. Should I make the PR here or create a build script in Yggdrasil.jl?

@quinnj
Copy link
Owner

quinnj commented Mar 4, 2020

Yes, let's move it to a proper Yggrdasil.jl repo/build script.

@randyzwitch
Copy link
Author

@jmkuhn when you submit that PR, please link back to here, and I'll close this issue

@giordano
Copy link

giordano commented Mar 5, 2020

JuliaPackaging/Yggdrasil#589

@jmkuhn
Copy link
Contributor

jmkuhn commented Mar 5, 2020

Yes, I was planning to once everything was merged. Here is the current status:
Yggdrasil build script JuliaPackaging/Yggdrasil#589
DecFP_jll https://github.com/JuliaBinaryWrappers/DecFP_jll.jl
DecFP PR JuliaMath/DecFP.jl#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@giordano @randyzwitch @quinnj @jmkuhn