Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all public exports as public #647

Open
karloskalcium opened this issue May 2, 2024 · 1 comment
Open

Register all public exports as public #647

karloskalcium opened this issue May 2, 2024 · 1 comment

Comments

@karloskalcium
Copy link

mutagen lists itself as py.typed however several of the modules are considered private - see this for more information.

example: mutagen.File, mutagen.MutagenError are both stored in "_xx" files which is considered private.

Fixing this will eliminate errors from type checkers. Thanks!

@DidierMalenfant
Copy link

I'm hitting this too.

Public types look to be:

from mutagen._util import MutagenError
from mutagen._file import FileType, StreamInfo, File
from mutagen._tags import Tags, Metadata, PaddingInfo

Would it be ok to submit a PR with those 3 files renamed as util.py, file.py and tags.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants