Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp files not deleted? #5

Open
jingzhaoou opened this issue Jan 20, 2014 · 3 comments
Open

Temp files not deleted? #5

jingzhaoou opened this issue Jan 20, 2014 · 3 comments

Comments

@jingzhaoou
Copy link

Hi,

When I looked at the source code, I found that for

header:"/pdf/someHeader",
footer:"/pdf/someFooter",

Temporary files are generated. However, I don't see where those temp files are deleted. Would this become a problem when I have many PDF exports on my Grails website? Or am I missing something?

Thanks,
Jingzhao
@quorak
Copy link
Owner

quorak commented Jan 20, 2014

no, you have a point. merge requests are welcome, otherwise I'll have a look into it later.

@jingzhaoou
Copy link
Author

In that case, I will create a fork and see how to fix it. Once you review the code and think it as an improvement, I will submit a merge request.

This plugin is a must-have and life-saver for my projects. Great job!

Thanks,
Jingzhao

@salimhb salimhb mentioned this issue Apr 6, 2018
Merged
@rlovtangen
Copy link

This is fixed in fork rlovtangen/grails-wkhtmltopdf thanks to @salimhb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quorak @jingzhaoou @rlovtangen