Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Light theme Tajweed color rules in Dark Mode #2101

Open
1 task done
LomariPortfolio opened this issue Feb 28, 2024 · 2 comments
Open
1 task done

[feature]: Light theme Tajweed color rules in Dark Mode #2101

LomariPortfolio opened this issue Feb 28, 2024 · 2 comments

Comments

@LomariPortfolio
Copy link

Is there an existing issue for this feature?

  • There is no exsiting issue for this feature

Summary

The Light mode Tajweed color rules look a lot better than the Dark mode ones, as it causes me eye strain when trying to differentiate between "Permitted Maad 2 or 4 or 6 seconds", "Necessary Maad 4 or 5 seconds" and "Maad 2 seconds" colors

image
image

It seems the color codes for them (in dark mode) are:
#d21ffb Maad 2 seconds
#ee30fa Permitted Maad 2 or 4 or 6 seconds
#ff55f1 Necessary Maad 4 or 5 seconds

I tried to compare them in Adobe Colors and they don't seem to be that much different:

image

image

image

image

Your purposed solution for this feature

Using the Light Mode version of the Tajweed color rules would be sufficient to stop users from having eye strain, also maybe using HSL/HSB instead of RGB can help making sure the colors contrast well.

And Jazakum Allah (Subhanahu Wa Ta'ala) alfa khair | وجزاكم الله سبحانه وتعالى ألف خير

@sharabash
Copy link
Member

Or perhaps customizable tajweed color settings for the next generation tajweed mushaf implementation (assuming we're implementing as a character-by-character font @osamasayed)

@osamasayed
Copy link
Member

osamasayed commented Jun 20, 2024

Or perhaps customizable tajweed color settings for the next generation tajweed mushaf implementation (assuming we're implementing as a character-by-character font @osamasayed)

We are working on adding a much higher-quality version of the Tajweed Mushaf that will have an in-Quran-Reader Tajweed rules section with fixed colors in the first version so users don't have to go back and forth between the Quran Reader and the Tajweed rules page and we will remove the dedicated rules pages as it will no longer be needed. Product details can be found here QF-545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants