Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Selected language is not persisting when revisiting quran.com #2104

Open
1 task done
3rg1s opened this issue Mar 5, 2024 · 2 comments
Open
1 task done

[bug]: Selected language is not persisting when revisiting quran.com #2104

3rg1s opened this issue Mar 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@3rg1s
Copy link

3rg1s commented Mar 5, 2024

Is there an existing issue for this?

  • There is no exsiting issue for this bug

Describe the bug

Setting a language perviously would cause the web app to keep the setting and have that language, as it takes the value from the NEXT_LOCALE cookie. The issue is only visible on prod and on beta environments. Also the NEXT_LOCALE cookie is set all the times.

Relevant log output

No response

Steps to reproduce

  1. Visit quran.com
  2. Click the globe icon and choose a language
  3. Close the tab and reopen quran.com

Environment (please complete the following information) and Add any other context about this bug

Tested on Macbook pro:

  1. Safari -> Version 17.3.1 (19617.2.4.11.12)
  2. Chrome -> Version 122.0.6261.94 (Official Build) (arm64)
  3. Brave -> Version 1.63.165 Chromium: 122.0.6261.94 (Official Build) (arm64) -- Based on chrome
  4. Firefox -> Version 123.0.1 (64-bit)

Environment

Production(quran.com)

@3rg1s 3rg1s added the bug Something isn't working label Mar 5, 2024
@fajicbenjamin
Copy link

Weird, I experience same on production site, but no issue when run it locally! Is it same for you?

Also, was wondering, is prefixing default locale maybe nice to have generally? From what I can see NEXT_LOCALE cookie works only when app is opened on /, so for example even with the cookie, if you open not prefixed URL on some surah or any other page, you won't get language from cookie?

@3rg1s
Copy link
Author

3rg1s commented Mar 8, 2024

Weird, I experience same on production site, but no issue when run it locally! Is it same for you?

Also, was wondering, is prefixing default locale maybe nice to have generally? From what I can see NEXT_LOCALE cookie works only when app is opened on /, so for example even with the cookie, if you open not prefixed URL on some surah or any other page, you won't get language from cookie?

Yes it does work locally for me. Well If i set a language and then goto /login, it wont change the language to the one I have set, so indeed it does set it when opening /

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants