Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Non-existant ayat should return 404 but returns 500 #468

Closed
matmar10 opened this issue Aug 28, 2016 · 10 comments · Fixed by #708
Closed

Non-existant ayat should return 404 but returns 500 #468

matmar10 opened this issue Aug 28, 2016 · 10 comments · Fixed by #708

Comments

@matmar10
Copy link

matmar10 commented Aug 28, 2016

Steps to reproduce:

Actual behavior:

  • 500 status code
  • Generic "Internal server error" page

Expected behavior:

  • 404 status code
  • Friendly "Ayat not found" error page
@mmahalwy
Copy link
Contributor

+1 on this

@matmar10
Copy link
Author

I will take a stab at this.

@ahmedre
Copy link
Contributor

ahmedre commented Aug 29, 2016

link to corresponding api task here - quran/quran.com-api#74 - not sure if the api is doing the right thing or not, we should check that first.

@mmahalwy
Copy link
Contributor

@ahmedre might not

@naveed-ahmad
Copy link
Contributor

@ahmedre @mmahalwy API is fine, following api call will return empty array as it should. Frontend should handle this case.

https://quran.com/api/v2/surahs/1/ayahs?from=10&to=12

@mmahalwy
Copy link
Contributor

mmahalwy commented Jan 9, 2017

@matmar10 any luck on this?

@aslamhadi
Copy link
Contributor

how is this going? or do we have mockup on how should the website look like when this happens? maybe I can help 🙇

@mmahalwy
Copy link
Contributor

We do need help! @aslamhadi want to take it over?

@abdulapopoola
Copy link
Contributor

I should inshaaha Allaah be able to pick this one; @aslamhadi do you want to take this one? If not, I can take a stab.

@aslamhadi
Copy link
Contributor

I'm working on it :) @mmahalwy @abdulapopoola

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants