Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken, again #102

Closed
mikegerber opened this issue Dec 21, 2023 · 4 comments
Closed

Tests broken, again #102

mikegerber opened this issue Dec 21, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mikegerber
Copy link
Member

https://github.com/qurator-spk/dinglehopper/actions/runs/7285741554/job/19868158221?pr=101

May be because it was a PR.

@mikegerber mikegerber added the bug Something isn't working label Dec 21, 2023
@mikegerber mikegerber self-assigned this Dec 21, 2023
@mikegerber
Copy link
Member Author

Tests ran fine after merging, so this was something related to that it was a PR.

@sadra-barikbin
Copy link
Contributor

@mikegerber , Failing tests in PRs is seemingly due to the fact that workflows triggered by pull_request event are not granted access to do certain things, e.g. to create checks as does the test-reporter here:

- name: Report tests
uses: dorny/test-reporter@v1
if: success() || failure()
with:
name: Results on Python ${{ matrix.python-version }}
path: "${{env.test_results_dir }}/junit.xml"
reporter: java-junit

We could add a separate workflow file triggered by workflow_run which could be granted access to create checks and move the above step there. Please see this and this. I would make the PR if you will.

@mikegerber
Copy link
Member Author

@sadra-barikbin Yes, exactly! I will take my time to review this though, dangerous territory ;)

@mikegerber
Copy link
Member Author

Should be fixed with @sadra-barikbin's PR #103, merged in 788868b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants